Refactor Redshift Append #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nathan-artie This unblocks the append mode for reader. We just need to rewrite the dedupe query and we can enable it for Redshift deploys. |
nathan-artie
reviewed
May 2, 2024
clients/redshift/writes.go
Outdated
| fmt.Sprintf(`ALTER TABLE %s APPEND FROM %s;`, tableID.FullyQualifiedName(), temporaryTableID.FullyQualifiedName()), | ||
| ) | ||
| return err | ||
| return shared.Append(s, tableData, types.AppendOpts{TempTableID: tableID}) |
There was a problem hiding this comment.
Is this comment outdated now:
transfer/lib/destination/types/types.go
Line 48 in 4153191
There was a problem hiding this comment.
Yes it is. I'm removing that whole option
nathan-artie
approved these changes
May 2, 2024
nathan-artie
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Instead of creating a separate staging table and then running
ALTER TABLE APPEND, we can just directly load this data into the Redshift table.By doing this, we don't have to worry about the edge cases of ALTER TABLE APPEND like having distribution mode clashes.